search

B3none / csgo-retakes-instadefuse

Allows a CT to instantly defuse the bomb when nothing can prevent defusal.
69 stars 15 forks source link

Map Vote issue #24

Closed gouyeh closed 1 year ago

gouyeh commented 4 years ago

Hello, End of the match map votes are not showing auto changing to random map. When disable this plugin map votes are working. Please fix thiss

RoyZ-iwnl commented 4 years ago

same issue

zahti commented 4 years ago

I have the same exact issue with the latest release 1.4.0. @b3none Any ideas for what to try?

When plugin is loaded:

May  1 20:10:51:  L 05/01/2020 - 20:10:51: World triggered "Round_Start"
May  1 20:10:52:  L 05/01/2020 - 20:10:52: "Zahti<2><STEAM_1:1:16728297><TERRORIST>" triggered "Planted_The_Bomb"
May  1 20:11:33:  L 05/01/2020 - 20:11:33: Team "TERRORIST" triggered "SFUI_Notice_Target_Bombed" (CT "0") (T "1")
May  1 20:11:33:  L 05/01/2020 - 20:11:33: Team "CT" scored "0" with "0" players
May  1 20:11:33:  L 05/01/2020 - 20:11:33: Team "TERRORIST" scored "1" with "1" players
May  1 20:11:33:  L 05/01/2020 - 20:11:33: World triggered "Round_End"
May  1 20:11:33:  L 05/01/2020 - 20:11:33: "Zahti<2><STEAM_1:1:16728297><TERRORIST>" [-81 -1362 1723] was killed by the bomb.
May  1 20:11:58:  CHANGELEVEL: Looking for next level in mapgroup 'mg_retakes'
May  1 20:11:58:  Looking for next map in mapgroup 'mg_retakes'...
May  1 20:11:58:  CHANGELEVEL: Choosing map 'de_dust2' (previous was de_cache)
May  1 20:11:58:  CHANGELEVEL: Looking for next level in mapgroup 'mg_retakes'
May  1 20:11:58:  Looking for next map in mapgroup 'mg_retakes'...
May  1 20:11:58:  CHANGELEVEL: Choosing map 'de_dust2' (previous was de_cache)
May  1 20:11:58:  CHANGE LEVEL: de_dust2
May  1 20:11:58:  RecordSteamInterfaceCreation (PID 13): SteamGameStats001 /
May  1 20:11:58:  message repeated 2 times: [ RecordSteamInterfaceCreation (PID 13): SteamGameStats001 /]
May  1 20:11:58:  L 05/01/2020 - 20:11:58: [META] Loaded 0 plugins (1 already loaded)
May  1 20:11:58:  ---- Host_Changelevel ----
May  1 20:11:58:  L 05/01/2020 - 20:11:58: [META] Loaded 0 plugins (1 already loaded)
May  1 20:11:58:  *** Map Load: de_dust2: Map Group mg_retakesL 05/01/2020 - 20:11:58: Log file closed
May  1 20:11:58:  Server logging data to file logfiles/L172_107_198_106_27041_202005012011_000.log
May  1 20:11:58:  L 05/01/2020 - 20:11:58: Log file started (file "logfiles/L172_107_198_106_27041_202005012011_000.log") (game "<dir>") (version "7803")
May  1 20:11:58:  L 05/01/2020 - 20:11:58: Loading map "de_dust2"
May  1 20:11:58:  L 05/01/2020 - 20:11:58: server cvars start

When plugin is unloaded:

Sarrus1 commented 3 years ago

I fixed this here: https://github.com/b3none/retakes-instadefuse/pull/32/commits/1b1a20c50f8571235fd5e231148b89ee17a8e70f

@gouyeh @RoyZ-CSGO @zahti

e1xom commented 3 years ago

@Sarrus1 The fix seems to work when I'm the sole player in the server, once there is more then 1 player in the server. The fix stopped working resulting in no mapvote at the end of the match and the server changing the map itself.

Any clues as to why and how to fix?

Sarrus1 commented 3 years ago

@e1xom Are you sure you are using the latest code and not the latest release instead?

If not, make sure you have mp_team_can_clinch 0 (that's what I have at least).

Otherwise I don't know, this seems to be working on my servers, you can test it on tensor.fr.

e1xom commented 3 years ago

I took your fixed retakes_instadefuse.sp with 342 total lines of code and replaced the old retakes_instadefuse.sp Everything else is the same as it was from the latest release.

I'll try your command and see if that fixes it. Thank you for the super fast reply! Are there any other files I should update?

Edit: I think the command you meant is mp_match_can_clinch since the mp_team_can_clinch gives unknown command returned in console.

2nd Edit: also even when I'm alone the server doesn't allow me to vote on the map anymore. Nothing changed how can this happen?

3rd Edit: These settings are forced as well, I really don't understand why the vote doesn't show up.

mp_endmatch_votenextmap 1 mp_endmatch_votenextleveltime 15

Sarrus1 commented 3 years ago

Make sure you have a mapgroup set, and make sure that everything works without the plugin.

e1xom commented 3 years ago

Everything is working properly. I kept the amount of plugins running to a minimum on purpose.

Mapgroup is set and returns the proper value when using "print_mapgroup"

For the instadefuse plugin I have the following: retakes-instadefuse.smx (from the latest release) retakes-instadefuse.sp (your fixed code) all the translation files (from the latest release)

I don't understand why it stopped working.

When I replaced the original retakes-instadefuse.sp with your code, I went into the server and used mp_maxrounds 1 to test and see if the votemap would come up at the end and it did.

A day later I connect with some friends to the server and the mapvote simply doesn't show up anymore. I haven't changed anything to the server in the meanwhile, neither have I added any other files or plugins..

So frustrating, it's the last thing I need to get working then the server is working flawlessly.

Sarrus1 commented 3 years ago

Ah, so you only replaced the .sp file. .sp file are for writing plugins, the .smx file is the actual plugin, once it has been compiled. To apply the fixes, you need to compile the plugin with something like https://spider.limetech.io/, which is easier for beginners.

I can't send you the compiled version, because of GitHub restrictions, but you can do it yourself easily.

Make sure to delete the old .smx file!

e1xom commented 3 years ago

Alright, so to sum it up to see if I understand completely.

I take your code from the .sp file, which I put into the Spider Compiler, then I compile it and download it.

Upload the new .smx file and delete the old one.

Do I even need the .sp file on the server? I assume not?

Thank you for helping a beginner like me once again!

Sarrus1 commented 3 years ago

Do I even need the .sp file on the server? I assume not?

No, but it's useful to keep them there to keep track of the sourcecode of the plugins you have on your server.

And yes, you got it right 👍

Thank you for helping a beginner like me once again!

No problem, I was there once ;)

e1xom commented 3 years ago

image

Not sure what I did wrong to get this error?

I'm reinstalling it again step by step, whilst the server is offline then I'll reboot it. I'll keep you updated :)

Sarrus1 commented 3 years ago

I've uploaded a compiled binary here.

The error you got means the .smx file got corrupted somehow.

e1xom commented 3 years ago

I've uploaded a compiled binary here.

The error you got means the .smx file got corrupted somehow.

Seems like I did something wrong, not sure what. But it shows up loaded now, will report back shortly if the mapvote is working. Thank you for all your effort :)

Update: It seems to be working! @Sarrus1 you are my savior! Thank you so much!

crashzk commented 2 years ago

https://github.com/b3none/retakes-instadefuse/releases/tag/1.4.0