B612-Asteroid-Institute / adam_home

ADAM python client and notebooks
MIT License
13 stars 8 forks source link

Change PropagationParameter name stopOnImpactDistanceMeters to stopOnImpactAltitudeMeters #142

Closed carise closed 3 years ago

carise commented 3 years ago

resolves #141

The Python client changes have been tested against a Google Cloud deployment of the API that has the updated PropagationParameter name.

github-actions[bot] commented 3 years ago

Locust summary

Git references

Initial: 9c22c1f
Terminal: 769818f

adam/propagation_params.py
Changes:
codecov[bot] commented 3 years ago

Codecov Report

Merging #142 (aa297b2) into master (9c22c1f) will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files          27       27           
  Lines        2023     2023           
=======================================
  Hits         1290     1290           
  Misses        733      733           
Impacted Files Coverage Δ
adam/adam_processing_service.py 26.45% <ø> (ø)
adam/propagation_params.py 87.87% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c22c1f...aa297b2. Read the comment docs.