B612-Asteroid-Institute / precovery

Fast precovery of small body observations at scale
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

adam_core interfaces #89

Closed ntellis closed 7 months ago

ntellis commented 9 months ago

This PR adds:

As written, precover() and precover_many() both accept either a precovery.Orbit or an adam_core Orbits. They output the old PrecoveryCandidate and FrameCandidate, though - this way they don't break anything existing in cutouts or adam_etl.

To get the more useful PrecoveryCandidateQv, the constructor is:

PrecoveryCandidatesQv.from_precovery_candidates([cand1, cand2, cand3])

I think it will be easiest to just call this after running precovery normally, where desired.

ntellis commented 9 months ago

I also borrowed drop_duplicates from thor. This could probably be promoted to quivr

ntellis commented 9 months ago

Dependencies are borked here, may need to update to using pyproject.toml, as well as change some things with pyoorb in order to get this working.

ntellis commented 9 months ago

Adopt dockerfile structure for adam_core/adam_etl for installing pyoorb, switch to pyproject.toml due to recent setuptools main version.