BAAQMD / geotools

Tools to support GIS work in inventoryverse
0 stars 0 forks source link

Switch from lazyeval to rlang #3

Open arilamstein opened 3 years ago

arilamstein commented 3 years ago

As part of Resolve namespace conflicts among packages attached by library(inventory) we would like to remove all occurences of lazyeval in the codebase and replace them with rlang. According to RStudio: lazyeval has been superseded by rlang. We're working on better communicating these changes to the user with deprecation messages using lifecycle.

geotools has one usage of lazyeval:

filter_.SpatialDataFrame <- function (.data, ..., .dots) {
  dots <- lazyeval::all_dots(.dots, ..., all_named = TRUE)
  masks <- lazyeval::lazy_eval(dots, data = as.data.frame(.data@data))
  subset(.data, Reduce(`&&`, masks))
}

We should find a way to convert this code to use rlang, so that we can remove the package completely from our setup.