search

BALKANGraph / FamilyTreeJS

Build family tree app with BALKAN FamilyTreeJS library. Family Tree also called a genealogy or a pedigree chart, is a chart representing family relationships in a conventional tree structure.
50 stars 16 forks source link

Unhandled Runtime Error ReferenceError: oldPartnerData is not defined #15

Closed alzaq closed 2 years ago

alzaq commented 2 years ago

Hi BALKANGraph, I'd like to use your lib in our family history web application based on NextJS.

I found one issue in your addChildAndPartnerNodes function.

There is one line of code that is buggy.

oldPartnerData = JSON.parse(JSON.stringify(o)),

but the variable oldPartnerData is not defined before.

When I tried to simulate this bug in your code.balkan.app - there is no ReferenceError, but in my codebase, it doesn't work.

Please can you check that variable oldPartnerData is really useful? I don't see any benefit of this variable in your minified JS.

Thanks!

Ales

ZornitsaPesheva commented 2 years ago

Hi @alzaq, The bug is fixed in the latest version - 1.03.02 Thank you for reporting it.

alzaq commented 2 years ago

It works great, thank you @ZornitsaPesheva

Closing this issue.