BALaka-18 / rake_new2

A Python library that enables smooth keyword extraction from any text using the RAKE(Rapid Automatic Keyword Extraction) algorithm.

MIT License

29 stars 20 forks source link

potential code refactor #43

Closed tusharnankani closed 3 years ago

tusharnankani commented 3 years ago

Description of the change

This PR includes:

remove unnecessary else used after break
Add @staticmethods, instead of using self. The method doesn't use its bound instance. Decorated the method with @staticmethod decorator, so that Python does not have to instantiate a bound method for every instance of this class thereby saving memory and computation.
Use Assertion Error: Whenever the use of assert is detected, the enclosed code will be removed when compiling to optimized byte code.
- The assert statement is generally for unit-testing or finding issues during the development process. This does not mean you will necessarily see the error. On the other hand, raising an AssertionError means that the error will be raised by the code and that any calling processes can deal with this error as needed.

What type of PR is this? (check all applicable)

[X] Refactoring existing code
[ ] Adding tests to existing code
[ ] New Feature
[ ] Bug Fix
[X] Optimization
[ ] Documentation Update

QA Instructions(if necessary), Screenshots of Output or Recordings

Please replace this line with instructions on how to test your changes

Added tests?

[ ] Yes
[X] No, because they aren't needed
[ ] No, because I need help

Added to documentation / readme or updated requirements.txt(if needed)?

[ ] Changed documentation in readme
[X] No documentation needed
[ ] Updated requirements.txt

codecov-io commented 3 years ago

Codecov Report

Merging #43 (9bd3eb8) into master (27aa4f6) will decrease coverage by 0.14%. The diff coverage is 0.99%.

@@            Coverage Diff            @@
##           master     #43      +/-   ##
=========================================
- Coverage    5.83%   5.69%   -0.15%     
=========================================
  Files           5       5              
  Lines         120     123       +3     
=========================================
  Hits            7       7              
- Misses        113     116       +3

Flag	Coverage Δ
unittests	`5.69% <0.99%> (-0.15%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
rake_new2/rake_new2.py	`0.00% <0.00%> (ø)`
tests/test_rake.py	`87.50% <50.00%> (-12.50%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27aa4f6...9bd3eb8. Read the comment docs.

BALaka-18 commented 3 years ago

@tusharnankani these are valuable changes, however, I made some changes to the code just 3-4 days back, it'd be great if you pull the current code and then make the changes that apply. I'll merge your PR then.

tusharnankani commented 3 years ago

I made some changes to the code just 3-4 days back, it'd be great if you pull the current code and then make the changes that apply.

Done 👍🏻 @BALaka-18