search

BAMRU-Tech / bamru_net

Internal bamru.net website
MIT License
7 stars 2 forks source link

Calendar Integration #132

Closed andyl closed 5 years ago

andyl commented 6 years ago

Integrate BAMRU.net V2 with our public calendar on BAMRU.org

kduncklee commented 6 years ago

I added the published filter. Please let me know if there is anything else you need for this.

jboning commented 6 years ago

Code is here: https://github.com/BAMRU-Tech/bamru-gcal

It seems to work well enough, though session timeout is probably an issue. When I get a chance (tomorrow or Thursday evening??) I'll look into adding OAuth support on the server-side, then we can switch the gcal tool to use that.

Unassigning myself for the operational side of things.

ctaylor451 commented 6 years ago

With the new system is there any reason not to integrate with event creation directly?

On Sun, Nov 11, 2018, 9:50 PM Josiah Boning notifications@github.com wrote:

Code is here: https://github.com/BAMRU-Tech/bamru-gcal

It seems to work well enough, though session timeout is probably an issue. When I get a chance (tomorrow or Thursday evening??) I'll look into adding OAuth support on the server-side, then we can switch the gcal tool to use that.

Unassigning myself for the operational side of things.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BAMRU-Tech/bamru_net/issues/132#issuecomment-437764418, or mute the thread https://github.com/notifications/unsubscribe-auth/AGj1gGUHCPEi7nppXh22oNbjvPag0RQlks5uuQwIgaJpZM4YDL_4 .

ctaylor451 commented 5 years ago

@jboning what's the status of this code? Would you propose an integration plan?

ctaylor451 commented 5 years ago

Texted @jboning waiting for reply on integration

jboning commented 5 years ago

As a minimal solution, I can set this up as a cron job running on a machine I have access to. I can do that tomorrow.

A better approach is to set this up as a cron job running on some bamru-managed machine. I can take a look at how to do that with our vagrant tooling on Sunday.

The ideal would be to update gcal events in realtime when events are created/edited/deleted on bamru.net. Even if we do this, though, we'll still want a cron job to periodically resync the calendar, in case some update request fails. So we might as well start with one of the first versions.

(Side note: The code I wrote only syncs to google calendar, not bamru.org. It looks like there's another (manual?) set of steps needed to update bamru.org. I'll look into that more on Sunday as well.)

Taking a step back: is any of this needed for MVP? Given that the public calendar is fairly stable, I don't think automatically updating the google calendar is critical within the next month or two.

ctaylor451 commented 5 years ago

Yes to MVP for google calendar of events, no to MVP for BAMRU.org calendar (but we should file an issue)

Can you provide me with an interface (python method call) for setting a calendar entry (title, date, description, lat, lon, location, leaders, etc) I'll integrate with the event create/edit code

On Thu, Nov 22, 2018 at 12:39 AM Josiah Boning notifications@github.com wrote:

As a minimal solution, I can set this up as a cron job running on a machine I have access to. I can do that tomorrow.

A better approach is to set this up as a cron job running on some bamru-managed machine. I can take a look at how to do that with our vagrant tooling on Sunday.

The ideal would be to update gcal events in realtime when events are created/edited/deleted on bamru.net. Even if we do this, though, we'll still want a cron job to periodically resync the calendar, in case some update request fails. So we might as well start with one of the first versions.

(Side note: The code I wrote only syncs to google calendar, not bamru.org. It looks like there's another (manual?) set of steps needed to update bamru.org. I'll look into that more on Sunday as well.)

Taking a step back: is any of this needed for MVP? Given that the public calendar is fairly stable, I don't think automatically updating the google calendar is critical within the next month or two.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BAMRU-Tech/bamru_net/issues/132#issuecomment-440953463, or mute the thread https://github.com/notifications/unsubscribe-auth/AGj1gJW-4NuGbAbMl8wnHZnMuZXP4Intks5uxmLOgaJpZM4YDL_4 .

jboning commented 5 years ago

Maybe I misunderstand the MVP--I thought the goal was to get an operationally stable system that we could use to send pages as soon as possible. (Maybe I'm out of date because I've been missing the Tuesday calls.)

I'll look at this now.

ctaylor451 commented 5 years ago

Thanks.

Current plan is to move completely, think Google beta. Operations have been difficult without a working system so we want to get all the components running. Kevin has the wiki upgraded with oauth. We're working to get all the functional pieces are in place, ideally by next week.

Cheers, Craig

On Fri, Nov 23, 2018, 12:18 PM Josiah Boning notifications@github.com wrote:

Maybe I misunderstand the MVP--I thought the goal was to get an operationally stable system that we could use to send pages as soon as possible. (Maybe I'm out of date because I've been missing the Tuesday calls.)

I'll look at this now.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BAMRU-Tech/bamru_net/issues/132#issuecomment-441312956, or mute the thread https://github.com/notifications/unsubscribe-auth/AGj1gFiLnWfe3iZoMMuOh7n3Nmi3MKaXks5uyFgLgaJpZM4YDL_4 .

jboning commented 5 years ago

I'm on the same page that we should move complete. I just don't think that google calendar sync is necessary to do that--it seems fine to add as part of "v1.5" in January (or whenever).

That said, I should have code to post shortly.

ctaylor451 commented 5 years ago

Thanks. You obviously don't live or die by your Google calendar ;-)

On Fri, Nov 23, 2018 at 2:21 PM Josiah Boning notifications@github.com wrote:

I'm on the same page that we should move complete. I just don't think that google calendar sync is necessary to do that--it seems fine to add as part of "v1.5" in January (or whenever).

That said, I should have code to post shortly.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BAMRU-Tech/bamru_net/issues/132#issuecomment-441324606, or mute the thread https://github.com/notifications/unsubscribe-auth/AGj1gEvVO0B3o9PEEcl6YvAO0Y62MaVsks5uyHT0gaJpZM4YDL_4 .

jboning commented 5 years ago

OK, #208 contains everything for calendar sync, including immediate updates on edits, except deployment configuration. I'll look into that.

ctaylor451 commented 5 years ago

Did you intend to reference #208 instead of #203?

What's left to do for incremental update, just add credentials?

jboning commented 5 years ago

Er, yep, I did. (Edited to fix.)

Just credentials. Working on that now.

ctaylor451 commented 5 years ago

We also have a bamru test calendar account. Do you needed it?

On Fri, Nov 23, 2018, 8:51 PM Josiah Boning notifications@github.com wrote:

Er, yep, I did.

Just credentials. Working on that now.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BAMRU-Tech/bamru_net/issues/132#issuecomment-441343599, or mute the thread https://github.com/notifications/unsubscribe-auth/AGj1gFY7LBo-T90sYL6IpfoRWZ1rDL2Nks5uyNBWgaJpZM4YDL_4 .

jboning commented 5 years ago

The credentials on the wiki for that are up to date (thanks Andy!) so I've been using it to test already.

ctaylor451 commented 5 years ago

What's the next step? I'd like to setup my dev env and test it out

jboning commented 5 years ago

I just landed the PR, so if you pull and run the vagrant setup on your dev env, you should be able to see event changes reflected in the bamru.caltest gcal.

ninjadeathtoast commented 5 years ago

Agree that this isn't a critical issue for posting to bamru.org, but since we do have recruiting season starting with guests probably trying to look up dates, can it be "slightly more important than other less-important things"?

Or we don't publish and test their resourcefulness ;)

ctaylor451 commented 5 years ago

It's pretty much done. Josiah implemented the code so it just needs a little more work to deploy. Currently it generates a 500 error that we haven't had time to look at

On Mon, Dec 3, 2018, 3:51 PM ninjadeathtoast notifications@github.com wrote:

Agree that this isn't a critical issue for posting to bamru.org, but since we do have recruiting season starting with guests probably trying to look up dates, can it be "slightly more important than other less-important things"?

Or we don't publish and test their resourcefulness ;)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BAMRU-Tech/bamru_net/issues/132#issuecomment-443915337, or mute the thread https://github.com/notifications/unsubscribe-auth/AGj1gF597A9MJA5GxSthuvdVFPW0NTeCks5u1bkfgaJpZM4YDL_4 .

jboning commented 5 years ago

Reference discussion on #231 - google calendar sync is now fully deployed!

I'll leave this issue open for getting updated info onto bamru.org as well. That looks like it shouldn't be hard--hopefully I'll have time to look at that soon.

kduncklee commented 5 years ago

Calendar is now automatically updating.