Closed marscher closed 2 years ago
Merging #46 (24022f6) into main (0c10c5e) will increase coverage by
1.16%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 71.79% 72.95% +1.16%
==========================================
Files 24 23 -1
Lines 1560 1553 -7
==========================================
+ Hits 1120 1133 +13
+ Misses 440 420 -20
Impacted Files | Coverage Δ | |
---|---|---|
weldx_widgets/tests/test_groove_sel.py | 100.00% <100.00%> (ø) |
|
weldx_widgets/visualization/csm_k3d.py | 87.74% <100.00%> (+1.03%) |
:arrow_up: |
weldx_widgets/widget_groove_sel.py | 93.41% <100.00%> (+3.25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0c10c5e...24022f6. Read the comment docs.
thanks, for some reason the 0 division exception even popped up without creating a file when switching to the 3d view tab, is that fixed as well?
This fixes two bugs in the visualization of the groove selection widget. The k3d plot needs to be displayed within the ipywidgets.Output capturing context. Secondly the STL export for a simple VGroove encountered a division by zero error. So for now this format is disallowed, and only PLY can be exported.