BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

Use weldx-widgets to reduce dependencies of weldx #749

Closed marscher closed 2 years ago

marscher commented 2 years ago

Changes

Use weldx-widgets

Related Issues

Closes #746

Checks

codecov[bot] commented 2 years ago

Codecov Report

Merging #749 (5bbe914) into master (418cf3d) will increase coverage by 0.96%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   95.81%   96.78%   +0.96%     
==========================================
  Files          92       90       -2     
  Lines        6500     5999     -501     
==========================================
- Hits         6228     5806     -422     
+ Misses        272      193      -79     
Impacted Files Coverage Δ
weldx/util/util.py 94.65% <66.66%> (-2.12%) :arrow_down:
weldx/transformations/local_cs.py 96.34% <75.00%> (-0.37%) :arrow_down:
weldx/visualization/__init__.py 95.23% <94.73%> (+7.73%) :arrow_up:
weldx/core.py 93.71% <100.00%> (+0.02%) :arrow_up:
weldx/geometry.py 96.60% <100.00%> (+0.01%) :arrow_up:
weldx/measurement.py 95.60% <100.00%> (+0.02%) :arrow_up:
weldx/transformations/cs_manager.py 98.79% <100.00%> (+<0.01%) :arrow_up:
weldx/visualization/colors.py 100.00% <100.00%> (+10.90%) :arrow_up:
weldx/visualization/types.py 100.00% <100.00%> (ø)
weldx/welding/groove/iso_9692_1.py 99.52% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 418cf3d...5bbe914. Read the comment docs.

github-actions[bot] commented 2 years ago

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 59s :stopwatch: +19s 2 145 tests  - 1  2 145 :heavy_check_mark:  - 1  0 :zzz: ±0  0 :x: ±0 

Results for commit 5bbe914f. ± Comparison against base commit 418cf3d1.

:recycle: This comment has been updated with latest results.

vhirtham commented 2 years ago

The title left me a bit confused since wxWidgets is a C++ GUI library 😄

marscher commented 2 years ago

@vhirtham We have discussed the mypy issue #752 and all linting issues left in PR are unrelated to the changes made. So in my opinion this is ready to be merged.

vhirtham commented 2 years ago

@marscher yes, we should ignore the mypy issues for now. I will start a new PR soon. However, the other linter errors (deepsource) should be fixed. I had a look at the reported issue. If the behavior is intended, just place a corresponding comment to the line so that it is ignored by deepsource. It complains about an open call with an external reference.

marscher commented 2 years ago

The code triggering this external open issue in _clean_notebook is a private function intended to clean notebooks, but I think this function is only a developer util, so it should be moved outside of the main package.

vhirtham commented 2 years ago

@marscher You can just silence the warning with # skipcq: + error code. For example # skipcq: PYL-W0622

CagtayFabry commented 2 years ago

cool !