search

BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

set networkx<=2.8.0 #761

Closed CagtayFabry closed 2 years ago

CagtayFabry commented 2 years ago

Changes

set networkx<=2.8.0 until CSM deepcopy is resolved see: https://github.com/BAMWelDX/weldx/runs/6502339152?check_suite_focus=true#step:9:110

Checks

codecov[bot] commented 2 years ago

Codecov Report

Merging #761 (fca56ce) into master (b6e9a33) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          88       88           
  Lines        6005     6005           
=======================================
  Hits         5817     5817           
  Misses        188      188

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6e9a33...fca56ce. Read the comment docs.

github-actions[bot] commented 2 years ago

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 36s :stopwatch: -41s 2 152 tests ±0  2 152 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit fca56ce7. ± Comparison against base commit b6e9a33f.

:recycle: This comment has been updated with latest results.

marscher commented 2 years ago

https://github.com/networkx/networkx/issues/2793 might be related, but is from 2017

CagtayFabry commented 2 years ago

looks like that could be related, yes

I don't really know what the cause is, if you do deepcopy(csm) it fails but deepcopy(csm._graph) seems to work

marscher commented 2 years ago

that is indeed super weird.

marscher commented 2 years ago

G.edges access also triggers the error, so it is completely unrelated to deepcopy, or pickle.