Closed marscher closed 2 years ago
note that the deepsource issues are unrelated to my changes :P
@vhirtham I've noticed, that using scipy as backend now triggers deprecation warnings like this:
DeprecationWarning: scipy.sin is deprecated and will be removed in SciPy 2.0.0, use numpy.sin instead
However we need to use scipy to make "Integrate" use the right backend. Do you have a suggestion how to proceed?
Merging #770 (85dc858) into master (eac3ca0) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #770 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 88 88
Lines 6014 6017 +3
=======================================
+ Hits 5820 5823 +3
Misses 194 194
Impacted Files | Coverage Δ | |
---|---|---|
weldx/core.py | 93.41% <ø> (ø) |
|
weldx/geometry.py | 96.61% <100.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eac3ca0...85dc858. Read the comment docs.
2 153 tests +1 2 153 :heavy_check_mark: +1 2m 24s :stopwatch: -11s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 85dc8584. ± Comparison against base commit eac3ca0a.
:recycle: This comment has been updated with latest results.
note that the deepsource issues are unrelated to my changes :P
I silenced it for the future ;)
Let me know if that helped with your old issues.
this looks great, nice find !
Changes
If we use the
Integrate
function in SymPy lambdify, we need to use "scipy" as method, "numpy" is not sufficient. xref: https://github.com/sympy/sympy/pull/20134Related Issues
Closes #725
Checks