BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

Update rtd_environment.yml #806

Closed CagtayFabry closed 1 year ago

CagtayFabry commented 1 year ago

Changes

use older nbformat due to MissingIDFieldWarning

Checks

codecov[bot] commented 1 year ago

Codecov Report

Merging #806 (a773535) into master (0c5ab61) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          81       81           
  Lines        5380     5380           
=======================================
  Hits         5208     5208           
  Misses        172      172           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

Test Results

2 185 tests  ±0   2 184 :heavy_check_mark: ±0   2m 37s :stopwatch: -1s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit 9661972e. ± Comparison against base commit 0c5ab616.

github-actions[bot] commented 1 year ago

Test Results

2 185 tests  ±0   2 184 :heavy_check_mark: ±0   3m 39s :stopwatch: + 1m 1s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit a7735357. ± Comparison against base commit 0c5ab616.

:recycle: This comment has been updated with latest results.

marscher commented 1 year ago

I think we would just need to fix our notebooks, e.g. each cell has to have an ID.

CagtayFabry commented 1 year ago

I think we would just need to fix our notebooks, e.g. each cell has to have an ID.

that would probably be the right solution 😁 I am not sure if the IDs get removed by some kind of script/hook atm though

If this doesn't work as a quick fix I am fine to leave it for now until we fix the notebooks