BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

Split up core in smaller sub modules #821

Closed marscher closed 1 year ago

marscher commented 1 year ago

Changes

Split up core in smaller sub modules, e.g. generic_series and mathematical_expression and so forth.

github-actions[bot] commented 1 year ago

Test Results

2 184 tests   - 1   2 183 :heavy_check_mark:  - 1   2m 34s :stopwatch: +2s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit 4e32e83a. ± Comparison against base commit e6f7d6a3.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #821 (4e32e83) into master (e6f7d6a) will increase coverage by 0.44%. The diff coverage is 99.12%.

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage   96.80%   97.25%   +0.44%     
==========================================
  Files          81       82       +1     
  Lines        5380     4913     -467     
==========================================
- Hits         5208     4778     -430     
+ Misses        172      135      -37     
Impacted Files Coverage Δ
weldx/geometry.py 96.61% <ø> (ø)
weldx/core/math_expression.py 98.50% <98.50%> (ø)
weldx/core/spatial_series.py 100.00% <100.00%> (ø)
weldx/core/generic_series.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

marscher commented 1 year ago

In my opinion the code is better maintainable, if modules are kept smaller.

The complains of static analysis are not new, but now show up as being newly introduced. Regarding the RTD issues, I'm not able to reproduce these locally. But I think they are also not related to the changes made here.