BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

build RTD with sphinx 5.1 #823

Closed CagtayFabry closed 1 year ago

CagtayFabry commented 1 year ago

Changes

Describe changes in this PR

Related Issues

Closes # (add issue numbers)

Checks

github-actions[bot] commented 1 year ago

Test Results

2 184 tests  ±0   2 183 :heavy_check_mark: ±0   3m 1s :stopwatch: -2s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit 23e75d2a. ± Comparison against base commit cfac317d.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #823 (23e75d2) into master (e6f7d6a) will increase coverage by 0.44%. The diff coverage is 99.12%.

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   96.80%   97.25%   +0.44%     
==========================================
  Files          81       82       +1     
  Lines        5380     4913     -467     
==========================================
- Hits         5208     4778     -430     
+ Misses        172      135      -37     
Impacted Files Coverage Δ
weldx/geometry.py 96.61% <ø> (ø)
weldx/core/math_expression.py 98.50% <98.50%> (ø)
weldx/core/spatial_series.py 100.00% <100.00%> (ø)
weldx/core/generic_series.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CagtayFabry commented 1 year ago

It appears the warnings where introduce by this change: https://github.com/sphinx-doc/sphinx/pull/10781

How ever, I don't see how we could restructure our documentation in this case (since we duplicate the docstring)

marscher commented 1 year ago

I do not think that this pinning is mandatory, as the build on RTD now proceeds without any warnings (after merging the 0.6.2 branch).

CagtayFabry commented 1 year ago

yes I just wanted to run this as a test to see where the error came from But I would rather stick with the changes in the 0.6.2 branch

Will close this now