search

BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

asdf-2.14.1 leads to a condition where weldx extension is found twice. #825

Closed marscher closed 1 year ago

marscher commented 1 year ago

This makes get_weldx_extension() fail, as the weldx extension is meant to be found only once. Eventually we register our extension in a legacy manner. Downgrading to asdf-2.13 circumvents this problem.

marscher commented 1 year ago

It seems one Extension contains all converters and tags, and the other does only contain tags. Screenshot_20221124_145829

marscher commented 1 year ago

Note that I released a quick fix build for conda-forge pinning asdf to <2.14

marscher commented 1 year ago

xref conda-forge/weldx-feedstock#22

marscher commented 1 year ago

@CagtayFabry another interesting observation is that on asdf-2.13 the legacy flag of the extension is False, while in asdf-2.14 it is True. But I cannot spot this change in upstream extension handling... Note that even asdf's extension is a legacy on 2.14

Its weird :hurtrealbad:

CagtayFabry commented 1 year ago

@CagtayFabry another interesting observation is that on asdf-2.13 the legacy flag of the extension is False, while in asdf-2.14 it is True. But I cannot spot this change in upstream extension handling... Note that even asdf's extension is a legacy on 2.14

Its weird :hurtrealbad:

that is indeed really weird, I suggest bringing this up in https://github.com/asdf-format/asdf/issues/1254 too and looking for clarification with the asdf devs on what is happening here

I have not followed the 2.14 release in depth so far

marscher commented 1 year ago

It looks like if you have an editable install (which we also do for our Github action pipeline), we get duplicated entry points.

WilliamJamieson commented 1 year ago

I think ASDF (thanks @braingram) may have fixed this bug in asdf-format/asdf#1260. Can you confirm that this resolves your bug? If so we will do a bugfix release ASAP for you.

CagtayFabry commented 1 year ago

I think ASDF (thanks @braingram) may have fixed this bug in asdf-format/asdf#1260. Can you confirm that this resolves your bug? If so we will do a bugfix release ASAP for you.

We will look into it, thank you for the heads up! @WilliamJamieson 🚀

marscher commented 1 year ago

@WilliamJamieson Thanks for providing this fix. It works like expected!

marscher commented 1 year ago

fixed upstream by asdf-format/asdf#1260