BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

Sphinx use myst-nb #830

Closed marscher closed 1 year ago

marscher commented 1 year ago

Changes

TODOs

Related Issues

Closes #745

Checks

github-actions[bot] commented 1 year ago

Test Results

2 184 tests  ±0   2 183 :heavy_check_mark: ±0   3m 57s :stopwatch: +39s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit c9cdd817. ± Comparison against base commit 132c5760.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #830 (c9cdd81) into master (132c576) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          92       92           
  Lines        6071     6071           
=======================================
  Hits         5879     5879           
  Misses        192      192           
Impacted Files Coverage Δ
weldx/transformations/cs_manager.py 98.60% <ø> (ø)
weldx/transformations/local_cs.py 96.34% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

marscher commented 1 year ago

Readthedocs is failing, because it cannot find conf.py (we moved that to doc/src/) and it then falls back to an autogenerated one.

CagtayFabry commented 1 year ago

Readthedocs is failing, because it cannot find conf.py (we moved that to doc/src/) and it then falls back to an autogenerated one.

The GH actions complains as well

Configuration error:
config directory doesn't contain a conf.py file (/home/runner/work/weldx/weldx/doc)
Error: Process completed with exit code 2.
marscher commented 1 year ago

Readthedocs is failing, because it cannot find conf.py (we moved that to doc/src/) and it then falls back to an autogenerated one.

There is a setting in the admin interface of RTD, but it seemed to be ignored :hankey:

marscher commented 1 year ago

rtd installs an old version of docutils (0.17), which makes the build fail. I'll try to pin to >0.19

CagtayFabry commented 1 year ago

begone RST 🧙 👍

marscher commented 1 year ago

:rofl: in fact autosummary/autodoc still uses RST a lot. But at least we do not have to write it our self any more.