BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

remove get_highest_tag_version from converters #831

Closed CagtayFabry closed 1 year ago

CagtayFabry commented 1 year ago

Changes

Checks

github-actions[bot] commented 1 year ago

Test Results

2 184 tests  ±0   2 183 :heavy_check_mark: ±0   2m 41s :stopwatch: +13s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit 3803954e. ± Comparison against base commit b825db9c.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #831 (3803954) into master (b825db9) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
- Coverage   96.83%   96.82%   -0.01%     
==========================================
  Files          92       92              
  Lines        6061     6055       -6     
==========================================
- Hits         5869     5863       -6     
  Misses        192      192              
Impacted Files Coverage Δ
weldx/tags/core/geometry/spatial_data.py 94.11% <ø> (-0.89%) :arrow_down:
weldx/tags/core/time_series.py 96.66% <ø> (-0.31%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CagtayFabry commented 1 year ago

thank you for pointing these out @marscher I have left get_highest_tag_version in there for now because it might be needed for the docs build (sphinx-asdf fork)