Closed WilliamJamieson closed 1 year ago
Thank you @WilliamJamieson π
We will probably consolidate this with #829 and discard older asdf versions for the next release to clean up some APIs as well (we are just slightly behind on the PRs over the holiday season π)
Thank you @WilliamJamieson π
We will probably consolidate this with #829 and discard older asdf versions for the next release to clean up some APIs as well (we are just slightly behind on the PRs over the holiday season π)
No problem, I noticed in the ASDF downstream tests that weldx was pinning ASDF, which made pip complain. However, everything seemed to be passing.
I didn't even check to see if you had a PR unpinning ASDF, so feel free to close this PR if you want.
I prefer this kind of pinning, where the incompatible versions are listed explicitly. Thanks a lot!
2β184 testsβ Β±0βββ2β183 :heavy_check_mark: Β±0βββ2m 28s :stopwatch: -11s βββββββ1 suites Β±0ββββββββββ1 :zzz: Β±0β βββββββ1 filesββ Β±0ββββββββββ0 :x: Β±0β
Results for commit d9efe8d2.βΒ± Comparison against base commit db750a4c.
Merging #834 (d9efe8d) into master (db750a4) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #834 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 92 92
Lines 6055 6055
=======================================
Hits 5863 5863
Misses 192 192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I prefer this kind of pinning, where the incompatible versions are listed explicitly. Thanks a lot!
I agree, however we don't currently run any compatibility tests for older asdf versions If we introduce those I would feel a bit more at ease keeping the older versions
Changes
This PR unpins asdf. In asdf version 2.14.3 we specifically fixed the bug introduced in asdf 2.14.0 which lead to #825. This means weldx should be able to unpin asdf now.
Note that I specifically excluded the asdf versions: 2.14.0, 2.14.1, and 2.14.2 as they all experience the bug reported in #825.
Related Issues
Closes #825
Checks