BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

Unpin maximum Python version #837

Closed marscher closed 1 year ago

marscher commented 1 year ago

Changes

We allow future versions again. A very detailed discussion why pinning maximum versions can be found here: https://iscinumpy.dev/post/bound-version-constraints/

Also fixed some dataclasses in asdf.tags.debug

TLDR: Never cap Python, it is fundamentally broken at the moment. Also, even packing capping has negative consequences that can produce unexpected solves.

Related Issues

Closes #836

Checks

codecov[bot] commented 1 year ago

Codecov Report

Merging #837 (4b2c772) into master (706cc95) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files          92       92           
  Lines        6071     6071           
=======================================
  Hits         5879     5879           
  Misses        192      192           
Impacted Files Coverage Δ
weldx/tags/debug/test_shape_validator.py 100.00% <100.00%> (ø)
weldx/tags/debug/test_unit_validator.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions[bot] commented 1 year ago

Test Results

2 184 tests  ±0   2 183 :heavy_check_mark: ±0   3m 35s :stopwatch: +9s        1 suites ±0          1 :zzz: ±0         1 files   ±0          0 :x: ±0 

Results for commit 4b2c772a. ± Comparison against base commit 140a038f.

:recycle: This comment has been updated with latest results.

marscher commented 1 year ago

Now we got the first evidence that pinning Python for libraries is a bad idea. Weldx-widgets depends on weldx, but this cannot be installed for Python 3.11. So it is an expected failure.