Closed CagtayFabry closed 1 year ago
1 files ± 0 1 suites ±0 1m 22s :stopwatch: - 1m 12s 2 134 tests - 55 2 048 :heavy_check_mark: - 140 1 :zzz: ±0 79 :x: +79 6 :fire: +6 2 137 runs - 52 2 048 :heavy_check_mark: - 140 1 :zzz: ±0 79 :x: +79 9 :fire: +9
For more details on these failures and errors, see this check.
Results for commit ad97c80d. ± Comparison against base commit 700850d2.
:recycle: This comment has been updated with latest results.
Python 3.9 seems to run into an issue with the fs
package in our test suite https://github.com/BAMWelDX/weldx/actions/runs/4626993379/jobs/8184371412
I could reproduce the error locally but I am nut sure what caused it, Python 3.10 seems to work again for some reason
Merging #865 (42806c8) into master (e68bb6d) will increase coverage by
0.02%
. The diff coverage is100.00%
.:exclamation: Current head 42806c8 differs from pull request most recent head ad97c80. Consider uploading reports for the commit ad97c80 to get more accurate results
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 96.48% 96.51% +0.02%
==========================================
Files 94 94
Lines 6230 6283 +53
==========================================
+ Hits 6011 6064 +53
Misses 219 219
Impacted Files | Coverage Δ | |
---|---|---|
weldx/asdf/file.py | 96.32% <100.00%> (+0.04%) |
:arrow_up: |
weldx/asdf/util.py | 90.88% <100.00%> (ø) |
|
weldx/asdf/validators.py | 98.24% <100.00%> (ø) |
|
weldx/config.py | 90.66% <100.00%> (ø) |
|
weldx/core/generic_series.py | 89.73% <100.00%> (+0.43%) |
:arrow_up: |
weldx/core/math_expression.py | 98.59% <100.00%> (ø) |
|
weldx/core/time_series.py | 97.72% <100.00%> (ø) |
|
weldx/geometry.py | 96.62% <100.00%> (+0.01%) |
:arrow_up: |
weldx/tags/core/common_types.py | 100.00% <100.00%> (ø) |
|
weldx/time.py | 97.88% <100.00%> (+0.04%) |
:arrow_up: |
... and 4 more |
... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I've seen this error before. It looks like the given path for the Quality standard is None. So it is not an issue with Python 3.9, but our code.
I've seen this error before. It looks like the given path for the Quality standard is None. So it is not an issue with Python 3.9, but our code.
yes but it only appears with 3.9 (at least for me)
Anyway, fs
seems rather unmaintained and is running into quite a few deprecation warnings, maybe we should try to find an alternative way (using asdf
tools)
the fewer dependencies the fewer points of failure. If asdf.tools provides a an alternative why not use it.
Unfortunately the initial changes slipped past on master here 700850d21970dadb7dfbd893eecf58c91ab86434
Changes
create release PR
vX.Y.Z
and add therelease
tag (example here)CHANGELOG.md
is up-to-date and enter current date to the release versionCITATION.cff
version number and datedeprecated
and remove deprecated codeMerge the Pull Request
add Git(hub) tag
ReadTheDocs updates
latest
,stable
andvX.Y.Z
get triggered on RTD (the tag build can get triggered twice, resulting in a failed/duplicated build, no need to worry)pypi release
build
action completes hereconda-forge release
meta.yaml
in the pull request, manually update all changes in the build and run dependencies