BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
20 stars 10 forks source link

fix pint 0.21 related errors #876

Closed CagtayFabry closed 1 year ago

CagtayFabry commented 1 year ago

Changes

Related Issues

closes #872

Checks

github-actions[bot] commented 1 year ago

Test Results

2 189 tests  ±0   2 188 :heavy_check_mark: +125   3m 3s :stopwatch: + 1m 1s        1 suites ±0          1 :zzz: ±    0         1 files   ±0          0 :x:  - 125 

Results for commit ee167b39. ± Comparison against base commit c2ee9b1f.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #876 (ee167b3) into master (c2ee9b1) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          94       94           
  Lines        6283     6283           
=======================================
  Hits         6064     6064           
  Misses        219      219           
Impacted Files Coverage Δ
weldx/geometry.py 96.62% <100.00%> (ø)
CagtayFabry commented 1 year ago

I looked into the mypy errors but could not figure out what the best way to implement type hints is now

Unfortunately the documentation for this is lacking in pint, so leaving as is for now (mypy passes with pint=0.20)