search

BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
19 stars 9 forks source link

fix WeldxFile doctest for asdf 3.0 #904

Closed braingram closed 6 months ago

braingram commented 6 months ago

Changes

As mentioned in https://github.com/BAMWelDX/weldx/pull/903

A doctest is failing due to changes in asdf 3.0 (including removal of BuiltinExtension) that result in slight and otherwise inconsequential header differences.

This PR expands the use of ... in the doctest to allow the text matching to ignore these header differences.

Checks

github-actions[bot] commented 6 months ago

Test Results

2 188 tests  ±0   2 187 :white_check_mark: +1   2m 3s :stopwatch: ±0s     1 suites ±0       1 :zzz: ±0      1 files   ±0       0 :x:  - 1 

Results for commit da105988. ± Comparison against base commit bb213a77.

marscher commented 6 months ago

LGTM as well. I do not get, why the notebook tests for Python 3.10 fail with an ImportError for WeldxFile.

braingram commented 6 months ago

That one is kind of puzzling.

I do see an error related to "quality_standard_demo": https://github.com/BAMWelDX/weldx/actions/runs/7398732873/job/20179218430?pr=904#step:12:82

File ~/work/weldx/weldx/quality_standard_demo/src/quality_standard_demo/__init__.py:1
----> 1 from ._version import __version__

ModuleNotFoundError: No module named 'quality_standard_demo._version'

It looks like the cookiecutter template here: https://github.com/BAMWelDX/quality-standard-template is rendered and installed: https://github.com/BAMWelDX/weldx/blob/bb213a77ee79e8c982adfec0d56b9d5a3efee7b1/.github/workflows/pytest.yml#L78 but is lacking a _version file (perhaps something has changed in setuptools-scm that it's no longer generating a _version.py?). The missing file appears to be preventing correct entry point loading for weldx which then leads to the ImportError for weldx.

CagtayFabry commented 6 months ago

Thank you for the fix @braingram !

I haven't had time yet to look into the issue regarding the quality standard template I will try to follow up with what you already found

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c94b182) 96.46% compared to head (da10598) 96.45%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #904 +/- ## ========================================== - Coverage 96.46% 96.45% -0.02% ========================================== Files 95 95 Lines 6287 6287 ========================================== - Hits 6065 6064 -1 - Misses 222 223 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CagtayFabry commented 6 months ago

I have updated the outdated build chain causing the issues https://github.com/BAMWelDX/quality-standard-template/pull/20

Thanks again @braingram