search

BAMWelDX / weldx

The welding data exchange format
https://www.bam.de/weldx
BSD 3-Clause "New" or "Revised" License
19 stars 9 forks source link

pandas warning of deprecated `S` #909

Closed braingram closed 3 months ago

braingram commented 5 months ago

In the asdf CI (which tests weldx as part of it's downstream) I'm seeing the following warning message:

E   FutureWarning: 'S' is deprecated and will be removed in a future version, please use 's' instead.

See here for context: https://github.com/asdf-format/asdf/actions/runs/7717012615/job/21035144518?pr=1745#step:10:1148

This might be coming from a use of a deprecated period alias but I can't quite pin down where this is coming from.

Is this a known issue? If so, do you recommend adding a warning filter to the asdf downstream job that tests weldx? Thanks!

CagtayFabry commented 5 months ago

Hi @braingram thank you for the heads-up

I guess this comes from some test cases that generate pandas time indexes. Unfortunately I am not sure when I have time to look into it further, it might be a while

braingram commented 5 months ago

Thanks for the response. I'll let you know if I find out anything more.

marscher commented 4 months ago

Have these aliases already been removed in Pandas-2.2?

braingram commented 4 months ago

I'm not sure (I'm honestly not that familiar with pandas).

A recent run of the asdf tests in weldx by the asdf downstream CI passed (with the warnings mentioned in this issue): https://github.com/asdf-format/asdf/actions/runs/8137112282/job/22342599707#step:10:404 using pandas 2.2 so I think that means the aliases have not yet been removed.

marscher commented 3 months ago

using pandas 2.2 so I think that means the aliases have not yet been removed.

you're right, they just have been deprecated. I general I really appreciate these kind of early failure notices! Thanks a lot.

@CagtayFabry Maybe we should have a workflow which turns deprecationwarnings and futurewarnings into exceptions and let it run weekly?