search

BAMresearch / FenicsConcrete

FE model representing the hardening of concrete
MIT License
1 stars 1 forks source link

fenicsX #12

Closed div-tyg closed 1 year ago

div-tyg commented 1 year ago

fenicsX implementation in fenics Concrete for linear elasticity example.

srosenbu commented 1 year ago

Thank you for pushing the example.

If we are planning on slowly replacing the FEniCS code with FEniCSX code, should this repo contain two setup.py? Or should the FEniCSX branch contain only FEniCSX code?

joergfunger commented 1 year ago

IMO, we should try to have only fenicsX code in that branch. The files that are not transformed should be somehow labeled and iteratively replaced.

srosenbu commented 1 year ago

I just updated the branch such that the legacy code is in a separate folder (labeled "legacy_code") and you can install fenicsXconcrete via pip install -e .

srosenbu commented 1 year ago

Since the linear elasticity example works in FEniCSx, I recommend closing this issue. I renamed the branch to main-FEniCSx and it is now protected like master. Any further development on the FEniCSx version should be branched from main-FEniCSx and merged into it later.