Rework noise models - Githubissues

BAMresearch / bayem

Implementation and derivation of "Variational Bayesian inference for a nonlinear forward model." [Chappell et al. 2008] for arbitrary, user-defined model errors.

MIT License

2 stars 1 forks source link

Rework noise models #27

Closed TTitscher closed 3 years ago

TTitscher commented 3 years ago

base everything on (me_key, sensor) pairs
remove all code duplication
add a test case
add example and try to explain it better
provide a 'split' method as reverse operation

TTitscher commented 3 years ago

Thanks for your comments, highly appreciated! Later today I plan to update the comments according to your remarks and additionally change the (then renamed) split method to not concatenate the individual vector of terms, but just return it. The simple np.concatenate(terms) can then be done elsewhere, if needed (only VariationalBayesProblem, I guess.)