BAN-AI-Communications / rfc2217-gateway

rfc2217-gateway: RFC-2217 gateway with mDNS announcement
https://github.com/SARAD-GmbH/rfc2217-gateway
Apache License 2.0
3 stars 0 forks source link

(PYL-W0201) Attribute defined outside `__init__` #10

Closed johnsonjh closed 3 years ago

johnsonjh commented 3 years ago

Description

Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init

Occurrences

There are 6 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/BAN-AI-Communications/rfc2217-gateway/issue/PYL-W0201/occurrences/

repo-ranger[bot] commented 3 years ago

⚠️ This has been marked to be closed in 7 days.

johnsonjh commented 3 years ago

3rd party / won't fix