search

BASIN-3D / basin3d-views

Simplified methods to view basin3d model objects
Other
0 stars 0 forks source link

latest version of mypy generates new errors #6

Closed dschristianson closed 1 year ago

dschristianson commented 1 year ago

Is your feature request related to a problem? Please describe. Yes. Existing code fails with version of mypy.

Consider:

# The new default is True. We may just want to set this to False
no_implicit_optional=False

# Either option raise errors
check_untyped_defs=(True|False)
dschristianson commented 1 year ago

Additional mypy error: error: Dataclass attribute may only be overridden by another attribute [misc] in timeseries.py because HDFTimeseriesData subclass properties try to overwrite SynthesizedTimeseriesData class variables.

Fix: make SynthesizedTimeseriesData class variables properties, add init.