search

BASIN-3D / basin3d

The core BASIN-3D application that uses a generalized data synthesis model that applies across a variety of earth science observation types (hydrology, geochemistry, climate etc.). https://basin3d.readthedocs.io/
Other
12 stars 4 forks source link

mypy issues in newer version #165

Open dschristianson opened 1 year ago

dschristianson commented 1 year ago

Describe the bug mypy has errors in newer version

To Reproduce From GitHub actions run: mypy -p basin3d --python-version 3.9

basin3d/core/synthesis.py:106: error: Missing named argument "data" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:106: error: Missing named argument "messages" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:269: error: Missing named argument "messages" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:280: error: Missing named argument "data" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:280: error: Argument "messages" to "SynthesisResponse" has incompatible type "list[Optional[SynthesisMessage]]"; expected "list[SynthesisMessage]"  [arg-type]

Expected behavior These errors should be corrected or the check disabled in this special case.

GitHub Actions

dschristianson commented 1 year ago

For now, ignored mypy call-arg errors until further discussion.