search

BASIN-3D / basin3d

The core BASIN-3D application that uses a generalized data synthesis model that applies across a variety of earth science observation types (hydrology, geochemistry, climate etc.). https://basin3d.readthedocs.io/
Other
12 stars 4 forks source link

Remove declaration of plugin_ids in the _init_catalog method when called in CatalogBase.initialize #207

Open dschristianson opened 1 week ago

dschristianson commented 1 week ago

In the core.catalog.CatalogBase.initalize method, a list of plugin_ids is passed to the _init_catalog method (which is specific to the type of catalog being used:

https://github.com/BASIN-3D/basin3d/blob/86bcd0dacdd3c7578fbbbecc7e293f0caff662b4/basin3d/core/catalog.py#L78

In the CatalogSqlAlchemy._init_catalog method, I cannot see where the list of plugin_ids passed in is used.

Also, the CatalogDjango (in django-basin3d) also does not currently make use of such a list.

Thus, does the parameter actually need to be passed in?

vchendrix commented 1 week ago

@dschristianson it does not need to be passed in.

dschristianson commented 1 week ago

OK, thanks. My sense is that we change in a future release.

vchendrix commented 1 week ago

OK, thanks. My sense is that we change in a future release.

agreed. It may give us more flexibility in the long run with catalog configuration