search

BASTAcode / BASTA

BASTA: The BAyesian STellar Algorithm
https://basta.readthedocs.io/
MIT License
21 stars 3 forks source link

Update Asfgrid #16

Closed jakobmoss closed 2 years ago

jakobmoss commented 2 years ago

The Asfgrid of dnu corrections has been updated (https://iopscience.iop.org/article/10.3847/2515-5172/ac8b12) with more points and an extended range. It can be downloaded from here: http://www.physics.usyd.edu.au/k2gap/Asfgrid/ . This could be quite an upgrade for the BaSTI library to complement the Serenelli corrections.

Update the code to use the new version -- REMEMBER that we patched the old version to work in BASTA. And that we added multiprocessing and therefore included some locks in the input to some routines.

Note: This is actually more of an issue for the building routines! I have made this issue just to make sure that we check to compatibility when the grids are updated.

jakobmoss commented 2 years ago

Looking at their Readme (http://www.physics.usyd.edu.au/k2gap/Asfgrid/readme.pdf), the transition should be easy:

  • The grid has been substantially upgraded with an extended range and finer spacing in mass and metallicity. To upgrade to the new version, simply download the directory with the data files and change the default data directory in line 150 of asfgrid.py to this directory.
  • However, the code asfgrid.py is the same as before.

I will double-check, but it seems that we can simply substitute the binary input files, modify a single line and then things will run.

jakobmoss commented 2 years ago

It works. The corrections are included in the BaSTI library available through BASTAdownload. At the next release, the plotting strings will be updated to reflect that we are now using the 2022-version.

jakobmoss commented 2 years ago

Fixed in version 1.1.6