search

BATgrowth / detect-bat-publishers

DEPRECATED: A npm package to detect Brave Browser / Basic Attention Token publishers
https://www.npmjs.com/package/detect-bat-publishers
MIT License
21 stars 3 forks source link

Numbers are hard #6

Closed da2x closed 5 years ago

da2x commented 6 years ago

“there are 896 detected Brave/BAT publishers amongst Alexa's Top 1M websites”

“Showing 1 to 300 of 592 entries”

Either it’s 592 or its 896 websites.

maxenceC commented 6 years ago

Websites that haven't been proccessed in the cron to gather their alexa rank aren't displayed yet in the table

I need to explain this somewhere

Thanks for the insight

Le ven. 13 juil. 2018 à 21:14, Daniel Aleksandersen < notifications@github.com> a écrit :

“there are 896 detected Brave/BAT publishers amongst Alexa's Top 1M websites”

“Showing 1 to 300 of 592 entries”

Either it’s 592 or its 896 websites.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BATgrowth/detect-bat-publishers/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AJVf_OyXeRjvpRoFDKWw2MyubLKuks-9ks5uGPGBgaJpZM4VPYbR .

marktolson commented 6 years ago

This is still wrong:

"As of today, there are 5324 detected Brave/BAT publishers amongst Alexa's Top 1M websites, that's 0.5324%"

According to the table there are less than 900 sites in the top 1 million. Most are in the 1 million-10 million rankings. The sentence should be:

"As of today, there are 5324 detected Brave/BAT publishers amongst Alexa's Top 10M websites, that's 0.05324%"

maxenceC commented 5 years ago

This was fixed in the last release