BATraining / adapt-dragAndDrop-public

A drag and drop question
GNU General Public License v3.0
3 stars 8 forks source link

width is fixed and doesn't adapt to iPad environment #3

Closed RosiniB closed 9 years ago

RosiniB commented 9 years ago

I tested the width and height settings and realized when viewing on the iPad the settings don't respond to the device, they remain fixed at the size i indicated in the JSON.

Can we have "_defaultWidth" and "_defaultHeight" not fixed dimensions to allow it to respond to the iPad? Maybe we can have a max width defined and make it scalable from that point.

RosiniB commented 9 years ago

I was under the impression from a discussion had in one of our calls that iPad is not considered a small device, therefore the components would appear similar as the desktop. We can discuss further on Wednesday to clarify but our preference is that components used on iPad in Landscape mode are the same as desktop (large to medium breakpoints)

RosiniB commented 9 years ago

I should also mention, to help clarify the comment above, the expectation is -dragAndDrop should appear on the iPad when orientation is Landscape and -objectMatching would replace it when orientation is Portrait.

amruta-thakur commented 9 years ago

@RosiniB : The component is switched based on the size and not on the orientation. The Drag and Drop component changes to Object matching only when the screen or window size goes below "large" size.

if (Adapt.device.screenSize == 'large') { this.render(); // for dragndrop } else { this.reRender();//switches to objectMatching }

As iPads have large resolutions, the framework returns screenSize="large" that is why it always appears as a Drag and Drop. Hope this clarifies the doubt.

RosiniB commented 9 years ago

@amruta-thakur : ok, thanks for clarifying, i will verify the behaviour.

RosiniB commented 9 years ago

I verified the component behaviour on the iPad and in landscape orientation, Object Matching is shown and we would rather it remain as Drag and Drop. Please see image capture from iPad.

image

aniketdharia commented 9 years ago

@RosiniB : which iPad and its iOS version are you testing on? please let us know.

Thanks! Regards, Aniket

amruta-thakur commented 9 years ago

We have tested it on iPad Mini and iPad3 and it seems working fine on it. Below are the screenshots for the same: image img_0226 img_0225

RosiniB commented 9 years ago

@aniketdharia : we've been testing on iPad Air, iOS v.8.3 and iPad 2, iOS v.7.0.4. Is there anything else we can try on our side, to find out why we are seeing the difference?

RosiniB commented 9 years ago

@aniketdharia : Can a link of your build be provided so we can directly verify here on our end and see what happens? thanks!

aniketdharia commented 9 years ago

Sure. I will send it via email in sometime.

aniketdharia commented 9 years ago

http://www.exultcorp.com/projects/bombardier/sample/index.html

RosiniB commented 9 years ago

Thanks for sharing the link Aniket. So in Landscape the components show up well, as intended but then if i turn to portrait, they don't adapt to the new breakpoint, see image below:

image