search

BBBsmoke / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Refactor glslang.y to reduce code duplication #911

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
There's a lot of code duplication in glslang.y. Also, the role of glslang.y in 
the system should be only to handle the grammar, with the details of the 
parsing being left to ParseContext.

Original issue reported on code.google.com by oetu...@nvidia.com on 11 Feb 2015 at 12:24

GoogleCodeExporter commented 9 years ago 
Project  : angle/angle
Branch   : master
Author   : Olli Etuaho <oetuaho@nvidia.com>
Committer: Zhenyao Mo <zmo@chromium.org>
Commit   : 72ba85bf7a8370152b377484e84cd9982cc29d18

Code-Review  0 : Jamie Madill, Nicolas Capens, Olli Etuaho
Code-Review  +2: Zhenyao Mo
Verified     0 : Jamie Madill, Nicolas Capens, Olli Etuaho
Verified     +1: Zhenyao Mo
Commit Queue   : Chumped
Change-Id      : I3459612f36185db861a361fa916cc6b671795037
Reviewed-at    : https://chromium-review.googlesource.com/255870

Fix regression in addFunctionCallOrMethod

Fix a crash when parsing a shader with incorrect constructor arguments.

BUG=angleproject:911
TEST=WebGL conformance tests

src/compiler/translator/ParseContext.cpp

Original comment by bugdro...@chromium.org on 4 Mar 2015 at 6:54