search

BBBsmoke / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

gn build missing angle_end2end_tests target #929

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Get a chromium tree
2. gn gen out\mygenoutput
3. ninja -C out/mygenoutput angle_end2end_tests

Expecting an angle_end2end_tests.exe to appear.

Instead:
ninja: Entering directory `out/mygenoutput'
ninja: error: unknown target 'angle_end2end_tests'

What version of the product are you using? On what operating system?

This was with current master of angle in Windows.

Original issue reported on code.google.com by brat...@opera.com on 25 Feb 2015 at 1:43

GoogleCodeExporter commented 9 years ago 
angle_unittests exists.

Original comment by brat...@opera.com on 25 Feb 2015 at 1:44

GoogleCodeExporter commented 9 years ago 
Ken, is this a missing target from ANGLE's BUILD.gn? I think you were doing 
integration with chrome at one point.

Original comment by jmad...@chromium.org on 25 Feb 2015 at 3:20

GoogleCodeExporter commented 9 years ago 
Yes, sorry, I was lazy and didn't port this target from src/gpu/gpu.gyp to 
src/gpu/BUILD.gn. There's still a TODO in gpu.gyp. Should I do it or could one 
of you pick it up?

Original comment by kbr@chromium.org on 25 Feb 2015 at 6:33

GoogleCodeExporter commented 9 years ago 
I'll leave it up to you for now. We can revisit in the future if no one has 
grabbed it since.

Original comment by jmad...@chromium.org on 26 Feb 2015 at 4:41

GoogleCodeExporter commented 9 years ago

Original comment by kbr@chromium.org on 26 Feb 2015 at 5:54