BBC-archive / psammead

React component library for BBC World Service and more
https://bbc.github.io/psammead/
Other
320 stars 54 forks source link

Dual-calendar timestamps for Persian and Pashto #1732

Closed jamesdonoh closed 5 years ago

jamesdonoh commented 5 years ago

Is your feature request related to a problem? Please describe. Following the investigation in https://github.com/bbc/simorgh/issues/1567 we have decided to add support for dual calendar (Gregorian and Jalali) timestamps to psammead-locales.

The implementation can reuse some of the code and tests from the legacy moment-ws codebase as it has been extensively validated in production, but it should be reviewed for correctness and modernised/tidied up before being integrated into psammead.

Describe the solution you'd like

Describe alternatives you've considered See https://github.com/bbc/simorgh/issues/1567

Testing notes

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context Add any other context or screenshots about the feature request here.

ibMadbouly commented 5 years ago

the dual calendar conversion is waiting on issue #1788