[BUG] Attachment uploads and Comments not working

BBMRI-ERIC / negotiator-frontend

The BBMRI-ERIC Negotiator is a service for structured negotiation with biological resources dealing with human data and/or biological samples. The reference implementation for the frontend is available in this repository.

https://negotiator-v3.bbmri-eric.eu

4 stars 3 forks source link

[BUG] Attachment uploads and Comments not working #255

Closed konradlang closed 1 month ago

konradlang commented 1 month ago

Describe the bug Responding to a request with an attachment does not record the message. UI: v1.4.2 Application: v3.6.1

How to reproduce

write a text in the response
attach the file
select Everyone
Send message

What happens Nothing goes into the message.

What should happen Messages are recorded and shown, attachments are uploaded and shown.

iblanque commented 1 month ago

Attachments in forms in negotiations are not working either.

Frontend version: 1.5.2 (docker tag 1.5)
Element of type "FILE" marked as "required"
The Frontend shows a message "Please fill out all required fields correctly" and it does not progress.
The attachment is not uploaded and there is no error message in the logs of the frontend or the backend.

RadovanTomik commented 1 month ago

Managed to reproduce it locally. @tmilost can you fix it? Should be relatively easy. The bug is caused by marking a field of type file as required. The frontend does not register that the file for that field was added.