search

BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://bbmri-eric.github.io/negotiator
GNU Affero General Public License v3.0
22 stars 8 forks source link

feat: negotiation pagination #144

Closed RadovanTomik closed 9 months ago

RadovanTomik commented 9 months ago

Negotiator pull request:

Description:

Adds pagination support for Negotiation endpoints.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (6ddc240) 76.07% compared to head (3d72a2c) 30.92%. Report is 2 commits behind head on master.

Files Patch % Lines
.../negotiator/mappers/NegotiationModelAssembler.java 32.14% 53 Missing and 4 partials :warning:
...iator/api/controller/v3/NegotiationController.java 0.00% 24 Missing :warning:
...ice/negotiator/service/NegotiationServiceImpl.java 0.00% 17 Missing :warning:
...e/negotiator/api/controller/v3/UserController.java 0.00% 7 Missing :warning:
...egotiator/converters/NegotiationRoleConverter.java 0.00% 4 Missing :warning:
...otiator/converters/NegotiationStatusConverter.java 0.00% 4 Missing :warning:
.../negotiator/api/controller/v3/NegotiationRole.java 0.00% 3 Missing :warning:
...e/negotiator/api/controller/v3/PostController.java 0.00% 2 Missing :warning:
...csit/service/negotiator/database/model/Person.java 33.33% 2 Missing :warning:
.../service/RepresentativeNegotiationServiceImpl.java 0.00% 2 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #144 +/- ## ============================================= - Coverage 76.07% 30.92% -45.15% + Complexity 754 345 -409 ============================================= Files 107 111 +4 Lines 1889 1992 +103 Branches 97 102 +5 ============================================= - Hits 1437 616 -821 - Misses 383 1344 +961 + Partials 69 32 -37 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator-v3/pull/144/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/BBMRI-ERIC/negotiator-v3/pull/144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `?` | | | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator-v3/pull/144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `30.92% <19.35%> (-1.43%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.