BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
4 stars 8 forks source link

feat: add support for dynamic access-form #188

Closed RadovanTomik closed 5 months ago

RadovanTomik commented 6 months ago

Negotiator pull request:

Description:

Adds support for fetching dynamic forms using the REST API.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 73.88535% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 73.68%. Comparing base (f2b4eb4) to head (841288e). Report is 33 commits behind head on master.

Files Patch % Lines
...c/negotiator/database/model/AccessFormSection.java 76.92% 10 Missing and 2 partials :warning:
...gotiator/dto/access_form/AccessFormElementDTO.java 41.17% 3 Missing and 7 partials :warning:
...gotiator/dto/access_form/AccessFormSectionDTO.java 40.00% 3 Missing and 6 partials :warning:
...r/database/model/AccessFormSectionElementLink.java 66.66% 8 Missing :warning:
...c/negotiator/mappers/AccessFormModelAssembler.java 27.27% 7 Missing and 1 partial :warning:
...eric/negotiator/service/AccessFormServiceImpl.java 85.96% 8 Missing :warning:
...mri_eric/negotiator/database/model/AccessForm.java 82.05% 6 Missing and 1 partial :warning:
...gotiator/database/model/AccessFormSectionLink.java 75.00% 4 Missing and 2 partials :warning:
...c/negotiator/database/model/AccessFormElement.java 80.00% 4 Missing and 1 partial :warning:
...eric/negotiator/dto/access_form/AccessFormDTO.java 54.54% 3 Missing and 2 partials :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #188 +/- ## ============================================ + Coverage 73.21% 73.68% +0.47% - Complexity 777 854 +77 ============================================ Files 115 118 +3 Lines 2109 2356 +247 Branches 107 141 +34 ============================================ + Hits 1544 1736 +192 - Misses 485 517 +32 - Partials 80 103 +23 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/188/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `73.68% <73.88%> (+0.47%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/188/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `26.91% <19.10%> (-3.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.