search

BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
4 stars 8 forks source link

[REFACTOR] UserNotificationService #197

Open RadovanTomik opened 5 months ago

RadovanTomik commented 5 months ago

Clean up the UserNotificationService as the interface is getting too big and the implementation as well. Suggestion would be to simplify the interface to:

List<NotificationModel> getNotifications(Long personId);
NotificationModel createNotification(Long PersonId, String content)
NotificationModel createNotification(Long PersonId, String content, bool sendImmediateEmail)

Create a separate class for sending out pending email notifications.