Closed svituz closed 5 months ago
Attention: Patch coverage is 89.01099%
with 20 lines
in your changes are missing coverage. Please review.
Project coverage is 77.76%. Comparing base (
c8e2901
) to head (2fe76c4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Negotiator pull request:
Description:
This PR implements filtering and sorting for negotiations in the backend. The implementation changes the way the queries for Negotiation are applied. Indeed, using the Repository method naming would have needed too many methods, one per combination of filter parameters. Specification have been used. This allows to define a Criteria for each parameter and concatenate the parameters. This change allowed removing lots of NegotiationRepository's methods, since they are replaced by findAll(Spec, Pageable). Moreover, some of the NegotiationService methods have been changed to use the new Specification.
Checklist:
Make sure you tick all the boxes below if they are true or do not apply: