BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

Refactor/use internal resource #231

Closed asulis closed 2 months ago

asulis commented 4 months ago

Negotiator pull request:

Description:

Please provide a short description of what this PR is supposed to accomplish...

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.65%. Comparing base (8a2076c) to head (494c10e).

Files Patch % Lines
...ri_eric/negotiator/database/model/Negotiation.java 95.65% 0 Missing and 1 partial :warning:
...base/model/NegotiationResourceLifecycleRecord.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #231 +/- ## ============================================ - Coverage 77.93% 77.65% -0.28% - Complexity 909 915 +6 ============================================ Files 125 125 Lines 2773 2792 +19 Branches 161 163 +2 ============================================ + Hits 2161 2168 +7 - Misses 512 523 +11 - Partials 100 101 +1 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/231/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/231/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `77.65% <93.33%> (-0.28%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.