Add reminder emails functionality

jungwire commented 2 months ago

Negotiator pull request:

Description:

Introduces some changes to the notification email service by adding a functionality to send reminder emails for pending (negotiations that are under review) and stale (negotiations without ) to admins and representatives, respectively. The goal is to increase the responsiveness of biobanks/admins.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

[x] I have performed a self review of my code
[x] My code follows Google Java Code style
[ ] I have made my code as simple as possible
[x] I have added unit tests and the code coverage has not decreased
[ ] I have updated the documentation in all relevant places

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.50549% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.00%. Comparing base (e276f5c) to head (171e2fc).

Files	Patch %	Lines
...egotiator/service/UserNotificationServiceImpl.java	94.50%	1 Missing and 4 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #279 +/- ## ============================================ + Coverage 79.94% 80.00% +0.05% - Complexity 1006 1020 +14 ============================================ Files 136 136 Lines 3017 3095 +78 Branches 163 170 +7 ============================================ + Hits 2412 2476 +64 - Misses 505 516 +11 - Partials 100 103 +3 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/279/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/279/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `80.00% <94.50%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RadovanTomik commented 2 months ago

technically I think it is implemented correctly, @konradlang do you think it matches the desired functionality?

BBMRI-ERIC / negotiator