BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

feat: Add REST API endpoints for setting up Access forms #291

Closed RadovanTomik closed 2 months ago

RadovanTomik commented 2 months ago

Negotiator pull request:

Description:

Adds REST API endpoints for setting up Access forms. Test it using swagger.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.05195% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.67%. Comparing base (89ac01d) to head (645991b). Report is 8 commits behind head on master.

Files Patch % Lines
...egotiator/dto/access_form/AccessFormCreateDTO.java 80.00% 1 Missing :warning:
...ric/negotiator/dto/access_form/ElementLinkDTO.java 85.71% 1 Missing :warning:
...ric/negotiator/dto/access_form/SectionLinkDTO.java 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## ============================================ + Coverage 78.45% 79.67% +1.21% - Complexity 973 1012 +39 ============================================ Files 133 136 +3 Lines 2892 3036 +144 Branches 163 165 +2 ============================================ + Hits 2269 2419 +150 + Misses 522 516 -6 Partials 101 101 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/291/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/291/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `79.67% <98.05%> (+1.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RadovanTomik commented 2 months ago

yes, you can do it using src/main/java/eu/bbmri_eric/negotiator/dto/access_form/SectionLinkDTO.java and src/main/java/eu/bbmri_eric/negotiator/dto/access_form/ElementLinkDTO.java. They have an attribute element and section order which sets the position

svituz commented 2 months ago

Is it implemented in the controller?

RadovanTomik commented 2 months ago

yes, the DTOs are passed for the link operation.