BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

feat: add suport for new access form element types #312

Closed RadovanTomik closed 2 weeks ago

RadovanTomik commented 2 months ago

Negotiator pull request:

Description:

Adds new element types for access forms. See Swagger for new endpoints.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (4164a6d) to head (1c1e285).

Files Patch % Lines
...gotiator/service/AccessFormElementServiceImpl.java 35.00% 9 Missing and 4 partials :warning:
...c/negotiator/mappers/AccessFormModelAssembler.java 0.00% 5 Missing and 1 partial :warning:
...mri_eric/negotiator/mappers/ValueSetAssembler.java 77.77% 0 Missing and 2 partials :warning:
...i_eric/negotiator/service/ValueSetServiceImpl.java 85.71% 2 Missing :warning:
...tiator/api/controller/v3/AccessFormController.java 85.71% 1 Missing :warning:
...bbmri_eric/negotiator/database/model/ValueSet.java 91.66% 1 Missing :warning:
...u/bbmri_eric/negotiator/dto/ValueSetCreateDTO.java 83.33% 1 Missing :warning:
...java/eu/bbmri_eric/negotiator/dto/ValueSetDTO.java 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #312 +/- ## ============================================ - Coverage 79.93% 79.63% -0.30% - Complexity 1199 1226 +27 ============================================ Files 157 163 +6 Lines 3673 3747 +74 Branches 197 203 +6 ============================================ + Hits 2936 2984 +48 - Misses 598 617 +19 - Partials 139 146 +7 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/312/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `79.63% <75.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.