codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 90.38462% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 79.67%. Comparing base (
2bee2a9) to head (4c890a5).
| Files | Patch % | Lines |
|---|---|---|
| ...egotiator/service/UserNotificationServiceImpl.java | 88.09% | 0 Missing and 5 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #325 +/- ## ============================================ - Coverage 79.75% 79.67% -0.08% - Complexity 1095 1097 +2 ============================================ Files 147 148 +1 Lines 3284 3291 +7 Branches 180 176 -4 ============================================ + Hits 2619 2622 +3 - Misses 541 546 +5 + Partials 124 123 -1 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/325/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/325/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `79.67% <90.38%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Negotiator pull request:
Description:
This PR fixes memory consumption when retrieving attachments and sending notifications for big negotiations (i.e., negotiations with lot of resources)
Checklist:
Make sure you tick all the boxes below if they are true or do not apply: