BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

Feat/nightly dir sync #331

Closed asulis closed 1 month ago

asulis commented 1 month ago

Negotiator pull request:

Description:

This PR implements an automatic or on request sync task fwith Directory. All biobanks and collections are read from directory and compared with organizations and resources in the Negotiator. All the missing are added and all those already present are updated, if necessary. Work still in progress

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 21.16402% with 149 lines in your changes are missing coverage. Please review.

Project coverage is 20.95%. Comparing base (b99fac8) to head (ab38704).

Files Patch % Lines
...gotiator/service/MolgenisDirectorySyncService.java 0.00% 121 Missing :warning:
...otiator/service/MolgenisServiceImplementation.java 82.97% 8 Missing :warning:
...otiator/database/model/DirectorySyncJobRecord.java 0.00% 7 Missing :warning:
...controller/v3/MolgenisDirectorySyncController.java 0.00% 5 Missing :warning:
...gotiator/database/model/DirectorySyncJobState.java 0.00% 5 Missing :warning:
...ontroller/v3/tasks/ScheduledDirectorySyncTask.java 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #331 +/- ## ============================================= - Coverage 79.73% 20.95% -58.79% + Complexity 1095 335 -760 ============================================= Files 147 152 +5 Lines 3281 3470 +189 Branches 179 189 +10 ============================================= - Hits 2616 727 -1889 - Misses 541 2698 +2157 + Partials 124 45 -79 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/331/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `20.95% <21.16%> (-58.79%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.