BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

feat(lifecycle): add handling of a first representative for a resource #333

Closed RadovanTomik closed 1 month ago

RadovanTomik commented 1 month ago

Negotiator pull request:

Description:

This PR adds functionality to update the resource status in old Negotiations when the resource was marked as unreachable.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 73.84615% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 79.52%. Comparing base (b7bea35) to head (0739415). Report is 8 commits behind head on master.

Files Patch % Lines
...gotiator/service/ResourceLifecycleServiceImpl.java 0.00% 10 Missing :warning:
...r/handlers/NonRepresentedResourcesHandlerImpl.java 78.26% 4 Missing and 1 partial :warning:
...ic/negotiator/events/FirstRepresentativeEvent.java 85.71% 1 Missing :warning:
...otiator/listeners/FirstRepresentativeListener.java 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #333 +/- ## ============================================ - Coverage 80.03% 79.52% -0.51% - Complexity 1101 1109 +8 ============================================ Files 148 151 +3 Lines 3295 3340 +45 Branches 176 182 +6 ============================================ + Hits 2637 2656 +19 - Misses 535 561 +26 Partials 123 123 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `79.52% <73.84%> (-0.51%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RadovanTomik commented 1 month ago

add tests for event publishing and making sure this functionality doesn't update the state of other collections