BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

Feat/discovery services sync #344

Open asulis opened 1 month ago

asulis commented 1 month ago

Negotiator pull request:

Description:

This PR implements an automatic or on request sync task fwith Directory. All biobanks and collections are read from directory and compared with organizations and resources in the Negotiator. All the missing are added and all those already present are updated, if necessary. Work still in progress

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 87.11111% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (4a81f8e) to head (1b9afca).

Files Patch % Lines
...iator/service/BBMRIDiscoveryServiceClientImpl.java 83.70% 20 Missing and 2 partials :warning:
...dto/syncjobservice/DiscoverySyncJobServiceDTO.java 75.00% 2 Missing :warning:
...r/events/DiscoveryServiceSynchronizationEvent.java 71.42% 2 Missing :warning:
...lugins/resourcesync/listeners/JobEventManager.java 87.50% 2 Missing :warning:
...base/model/DiscoveryServiceSynchronizationJob.java 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #344 +/- ## ============================================ + Coverage 80.59% 80.98% +0.38% - Complexity 1228 1283 +55 ============================================ Files 160 170 +10 Lines 3716 3939 +223 Branches 203 211 +8 ============================================ + Hits 2995 3190 +195 - Misses 575 601 +26 - Partials 146 148 +2 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/344/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `80.98% <87.11%> (+0.38%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.