BBMRI-ERIC / negotiator

An Open-source access negotation system for Research Infrastructures
https://negotiator.bbmri-eric.eu
GNU Affero General Public License v3.0
3 stars 8 forks source link

Feat/enable public posts on submitted #346

Closed svituz closed 1 month ago

svituz commented 1 month ago

Negotiator pull request:

Description:

This PR enables public posts even before an administrator approves the negotiation. Private posts, instead, are still enabled only after approval

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.02%. Comparing base (787e522) to head (1d0d0a8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ============================================ + Coverage 79.85% 80.02% +0.17% - Complexity 1113 1123 +10 ============================================ Files 151 151 Lines 3340 3350 +10 Branches 182 185 +3 ============================================ + Hits 2667 2681 +14 + Misses 550 546 -4 Partials 123 123 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `80.02% <100.00%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RadovanTomik commented 1 month ago

oh and please rename the PR title to conventional commits