codecov[bot]
commented
3 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.61%. Comparing base (
4164a6d) to head (ebc7fe5).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #354 +/- ## ============================================ + Coverage 79.93% 80.61% +0.68% + Complexity 1199 1197 -2 ============================================ Files 157 154 -3 Lines 3673 3642 -31 Branches 197 197 ============================================ Hits 2936 2936 + Misses 598 567 -31 Partials 139 139 ``` | [Flag](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/354/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/BBMRI-ERIC/negotiator/pull/354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC) | `80.61% <ø> (+0.68%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BBMRI-ERIC#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Negotiator pull request:
This PR removes unnecessary entities PersonNegotiationRole and Role.
Description:
The PersonNegotiationRole was created to record the roles associated with a negotiation but, as a matter of fact, it was used to record only its creator, which is also registered in the createdBy attribute, thus resulting in information duplication. After removing PersonNegotiatioRole, also the Role entity was unnecessary since the role is always obtained from the token.
Checklist:
Make sure you tick all the boxes bellow if they are true or do not apply: